KJT custom op for 1d lengths input #2163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58956327 |
Summary: Pull Request resolved: #2163 X-link: pytorch/FBGEMM#2774 # context * move the `tensor.view(-1, stride)` from python into the operator (c++) * make the PT2 complier happy * reference: D58948987 # notes * not sure if we should directly change the op call in the jagged_tensor * tested in CPU * backward and GPU haven't tested Differential Revision: D58956327
|
This pull request was exported from Phabricator. Differential Revision: D58956327 |
TroyGarden
force-pushed
the
export-D58956327
branch
from
4290e0e to
ba4d674
Compare
IvanKobzarev
pushed a commit
to IvanKobzarev/FBGEMM
that referenced
this pull request
Jun 25, 2024
Summary: X-link: pytorch/torchrec#2163 Pull Request resolved: pytorch#2774 # context * move the `tensor.view(-1, stride)` from python into the operator (c++) * make the PT2 complier happy * reference: D58948987 # notes * not sure if we should directly change the op call in the jagged_tensor * tested on CPU and GPU * backward/autograd not tested Differential Revision: D58956327
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Jun 25, 2024
…h#2163) Summary: Pull Request resolved: pytorch#2163 X-link: pytorch/FBGEMM#2774 # context * move the `tensor.view(-1, stride)` from python into the operator (c++) * make the PT2 complier happy * reference: D58948987 # notes * not sure if we should directly change the op call in the jagged_tensor * tested on CPU and GPU * backward/autograd not tested Differential Revision: D59031938
facebook-github-bot
pushed a commit
to pytorch/FBGEMM
that referenced
this pull request
Jun 26, 2024
Summary: X-link: pytorch/torchrec#2163 Pull Request resolved: #2774 # context * move the `tensor.view(-1, stride)` from python into the operator (c++) * make the PT2 complier happy * reference: D58948987 # notes * not sure if we should directly change the op call in the jagged_tensor * tested on CPU and GPU * backward/autograd not tested Reviewed By: IvanKobzarev Differential Revision: D58956327 fbshipit-source-id: 0b07fd96c704251358cf3f58b11f842f6add32ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/FBGEMM#2774
context
tensor.view(-1, stride)from python into the operator (c++)notes
Differential Revision: D58956327